Skip to content

some minor pioasm fixes #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Remove unnecessary check in pio_encode_sideset_opt
merged 1 commit into from
Nov 21, 2024
Merged

some minor pioasm fixes #2056

merged 1 commit into from
Nov 21, 2024

Conversation

@kilograham
Copy link
Contributor

fixes #1950

@kilograham kilograham added this to the 2.1.0 milestone Nov 19, 2024
will-v-pi
will-v-pi approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@will-v-pi will-v-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and still compiles examples fine so seems to work

@kilograham kilograham merged commit 6bb3ccf into develop Nov 21, 2024
7 checks passed
@kilograham kilograham deleted the pioasm_fixes branch November 21, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@will-v-pi will-v-pi will-v-pi approved these changes

@peterharperuk peterharperuk Awaiting requested review from peterharperuk

Assignees

No one assigned

Labels

pioasm

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kilograham @will-v-pi